chore: Coverage Report - Githubissues

poetapp / node

The core of Po.et

https://docs.poetnetwork.net/

MIT License

192 stars 27 forks source link

chore: Coverage Report #897

Closed wzalazar closed 5 years ago

wzalazar commented 5 years ago

PR Process - PR Review Checklist

Release

Semantic release is enabled for this repository. Make sure you follow the right commit message convention. We're using semantic-release's default — Angular Commit Message Conventions.

Description of Changes

This PR introduces:

Runs all test together in the same thread to get the report coverage, unit test, integration test, and functional test.

In the past, we talked with @lautarodragan the possibility to get the coverage with the integration tests, etc. Today with the refactored we did the possibility is a reality. I leave this PR open to discussion.

Coverage summary

Statements : 91.97% ( 1719/1869 )
Branches : 69.91% ( 158/226 )
Functions : 91.65% ( 384/419 )
Lines : 92.19% ( 1628/1766 )

lautarodragan commented 5 years ago

This is awesome, and it shows that we really have great coverage!

Does this work too if we avoid ts-node?

wzalazar commented 5 years ago

well, today we don't have problems with ts-node, for another hand without ts-node we have a wrong report, for example, when you run npm run coverage:unit:

1..156
# tests 156
# pass  156

# ok

Coverage summary 
Statements   : 0% ( 0/1422 )
Branches     : 0% ( 0/208 )
Functions    : 0% ( 0/410 )
Lines        : 0% ( 0/1339 )

or when you run npm run coverage:integration

1..44
# tests 44
# pass  44

# ok

Coverage summary
Statements   : 0% ( 0/1422 )
Branches     : 0% ( 0/208 )
Functions    : 0% ( 0/410 )
Lines        : 0% ( 0/1339 )

I think we have to go back to ts-node

kennylavender commented 5 years ago

This is purely a guess, but my main guess as to why ts-node was acting funny was due to Inversify. Inversify was doing some out of the ordinary JS stuff using Reflection, I didn't really care to look into but I was thinking may have been the cause. Inversify is now removed though, so we may be good to switch back to ts-node.

wzalazar commented 5 years ago

@kennylavender I think the same, for me the problem was with Inversify, ;)

poet-ci commented 5 years ago

:tada: This PR is included in version 2.18.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: