search

poetapp / node

The core of Po.et
https://docs.poetnetwork.net/
MIT License
192 stars 27 forks source link

chore: Go Back to Ts-Node #917

Closed wzalazar closed 5 years ago

wzalazar commented 5 years ago

PR Process - PR Review Checklist

Release

Semantic release is enabled for this repository. Make sure you follow the right commit message convention. We're using semantic-release's default — Angular Commit Message Conventions.

Description of Changes

Fix https://github.com/poetapp/node/issues/916

lautarodragan commented 5 years ago

Is there documentation on why we need ts-node for good coverage?

wzalazar commented 5 years ago

@lautarodragan I left this comment on this ticket https://github.com/poetapp/node/pull/897

well, today we don't have problems with ts-node, for another hand without ts-node we have a wrong report, for example, when you run npm run coverage:unit:

1..156
# tests 156
# pass  156

# ok

Coverage summary 
Statements   : 0% ( 0/1422 )
Branches     : 0% ( 0/208 )
Functions    : 0% ( 0/410 )
Lines        : 0% ( 0/1339 )

or when you run npm run coverage:integration

1..44
# tests 44
# pass  44

# ok

Coverage summary
Statements   : 0% ( 0/1422 )
Branches     : 0% ( 0/208 )
Functions    : 0% ( 0/410 )
Lines        : 0% ( 0/1339 )

I think we have to go back to ts-node

poet-ci commented 5 years ago

:tada: This PR is included in version 2.18.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: