search

poetapp / poet-js

Po.et JS is an small library that provides methods to easily create and sign Po.et Claims.
https://www.npmjs.com/package/@po.et/poet-js
MIT License
52 stars 4 forks source link

Missing await #272

Open lautarodragan opened 5 years ago

lautarodragan commented 5 years ago

In this line isValidSignature is missing an await. The promise returned is truthy, always evaluates to true.

https://github.com/poetapp/poet-js/blob/f50a70120958765edf7f5317f918bedebbb6c2db/src/VerifiableClaimSigner.ts#L69-L70

This hasn't been an issue. This code is probably more suitable for a unit test. We could just remove it here and add a unit test.