search

poetic / ember-cli-cordova

A tool for creating hybrid apps using a combination of ember-cli and cordova
MIT License
441 stars 77 forks source link

Add support for ember 2.0 #193

Closed jcowley closed 8 years ago

jcowley commented 8 years ago

I'd like to be able to use ember-cli-cordova with my app, but found that it was not compatible with the latest versions of ember and ember-cli (2.3.0).

Aside from an upgrade to dependencies, this also switches to ember-gestures from the now deprecated ember-mobiletouch. ember-mobiletouch uses Views, which are gone in ember 2.0+.

@MatthewHager and/or @AlexBlom: Can you take a look at this PR and let me know if you see any issues? Happy to do some further work on this if required.

If there are no issues, I'd suggest that this be rolled out as a 0.1-beta release initially to get some feedback from people using ember-cli-cordova in existing apps.

Also note the PR here which will fix various broccoli-funnel deprecation warnings caused by the included qunit-bdd library: https://github.com/jakecraige/qunit-bdd/pull/1

jcowley commented 8 years ago

Ouch. Working on fixing the various 'hound' violations.

jcowley commented 8 years ago

Ok, CI build is now passing (it's not on master).

Anyone have a clue on the various 'esnext' errors generated by hound? I had "esnext": true set in .jshintrc when I submitted the PR.