search

poetic / meteor-reacterminator

Convert annotated html and css files to a functional meteor app.
15 stars 6 forks source link

A webflow export with apostrophes as html property values will break stanza update #57

Open JohnRodney opened 8 years ago

JohnRodney commented 8 years ago

<input autofocus="autofocus" class="input-field w-input" data-name="What&#39;s your address?" id="What-s-your-address" maxlength="256" name="What-s-your-address" placeholder="What&#39;s your address?" required="required" type="text">

In the case of a designer setting up a placeholder with a apostrophe the output webflow ends up using an html entity value which in turn breaks reacterminator from doing an update.

I'm not sure what the best solution here is but it would seem it would be to ask the designer not to use apostrophe's but in the case of trying to provide correct grammar for a input placeholder you would want this. Any ideas @Chun-Yang?

Chun-Yang commented 8 years ago

This is related to the the html parser I think. For now let's not use html entities there.

JohnRodney commented 8 years ago

@Chun-Yang so then the expected solution is for a third party aka a developer to convert these by hand before doing an update?

JohnRodney commented 8 years ago

Also I can move this issue to reacterminator if you would like I just put it here since it applies to how webflow does an export.

Chun-Yang commented 8 years ago

That would be great 👍

Chun-Yang commented 8 years ago

Reacterminator should fix it eventually. Ideally it should only be an option in the parser in reacterminator