poetic / nock-vcr-recorder

A test framework agnostic vcr implementation that uses nock.
9 stars 11 forks source link

Update nock to 8.0.0 #7

Closed divergentdave closed 8 years ago

divergentdave commented 8 years ago

This PR updates the nock dependency to the latest version. The test suite passes with the updated version.

I have found that when using nock-vcr-recorder, with nock 0.59.0, doesn't work well with axios. Specifically, when requesting a JSON document and recording a cassette for the first time, response.data will be the empty string, rather than a JSON object. After updating nock-vcr-recorder's nock dependency to 8.0.0, I tried the same thing again, and the response data came through fine, and the cassette was recorded successfully.