search

poetic / reacterminator

Convert html to react components in es6 syntax.
56 stars 6 forks source link

Add action creator into Param Store #32

Open Chun-Yang opened 8 years ago

Chun-Yang commented 8 years ago
  1. add action creator into ParamStore
  2. change Link component to accept the store?
  3. change reacterminator so that it use the new syntax?
  4. minimize API, remove setAll and getAll?
Chun-Yang commented 8 years ago

Right now, we pass store to ParamStore and use ParamStore as an action emitter. It seems a more 'redux' way to do it is to use an action creator. In another term, the API we have in ParamStore is leaky.

Also, ParamStore's api is leaky for another reason: we still use 'window.history.back' instead of something like 'ParamStore.back'.