search

pofider / node-wkhtmltopdf-installer

Installs wkhtmltopdf through NPM
MIT License
9 stars 9 forks source link

Provide release for version 0.12.4 of wkhtmltopdf binaries #8

Open ghost opened 7 years ago

ghost commented 7 years ago

Hello there,

Version 0.12.4 of wkhtmltopdf contains a fix that is likely to resolve some elusive JsReport render request failures that I've been observing in a production application. Would you be able to provide an updated release containing these binaries?

If needed, I'm happy to do up a pull request too (I assume it's simply a matter of creating the zipped up binaries for each OS with just the 64-bit version of the corresponding wkhtmltopdf binary).

pofider commented 7 years ago

Thank you for information. PR would be great.

Did you observe any "back compatibility" changes with previous version? Like that the output pdf would look visually different in sizes? Just checking if we can release this in minor version increase.

ghost commented 7 years ago

Apologies about the delayed reply.

Did you observe any "back compatibility" changes with previous version?

It appears I didn't do enough digging before making this request for version 0.12.4 of wkhtmltopdf. The Mac distribution appears to have a regression related to font scaling. I have JsReport running on a Ubuntu box, which is why I overlooked the latter issue. As such, feel free to close this off if you think it's better to wait for 0.12.5.

In the meanwhile, I've been trying to manually compile the wkhtmltopdf binary from source (because I can't find them being distributed) but with limited success. Do you happen to have any special instructions or tips to obtain statically-built binaries? (I assume somebody must've done this for the binaries that are distributed with this package).

pofider commented 7 years ago

I see. Seems the wkhtmtopdf runs into the same issue as phantomjs. The different versions are starting to produce different pdf element sizes. It will be anyway the best to let the developers decide explicitly which version of the binary should be used. I will look into it.

I've never tried to compile wkhtmltopdf from the sources. The binaries attached in this package are simply downloaded. Unfortunately I've no hints for you here.