pofider / phantom-html-to-pdf

Highly scalable html to pdf conversion using phantom workers
MIT License
159 stars 33 forks source link

Phantom path #19

Closed troyfendall closed 8 years ago

troyfendall commented 8 years ago

@pofider

Thanks for the great library! I tried it out and got PDF rendering from a URL working locally using the phantom-html-to-pdf module. I went to deploy to my AWS EC2 instance and found that the node phantomjs 1.9.15 doesn't properly load on Amazon Linux. To get around this, I implemented the ability to set a path to the phantomjs binary, which seems to be standard in other libraries that rely on phantom, e.g. https://github.com/brenden/node-webshot.

This change will work standalone for the dedicatedProcess strategy, but relies on https://github.com/pofider/phantom-workers/pull/10 for the server strategy. That will require a new release of https://github.com/pofider/phantom-workers and a change to the version of that dependency in package.json.

Testing:

pofider commented 8 years ago

Thank for PR.

Changes are released in the version 0.3.4