search

pofider / phantom-html-to-pdf

Highly scalable html to pdf conversion using phantom workers
MIT License
159 stars 33 forks source link

fix: tmpDir being ignored when set via conversionOptions #38

Closed Connum closed 7 years ago

pofider commented 8 years ago

I think this is intentional. tmpDir is global option and should not be part of the specific conversion options

ghost commented 7 years ago

This would allow one to use sometime like tmp (https://www.npmjs.com/package/tmp) to cleanup the temp files

bjrmatos commented 7 years ago

you can already use the reap package to clean up old files in any directory (we use it internally in jsreport and works great with any directory), the advantage to have this option as something global is that it is more easy to clean up one directory than cleaning multiple directories if the tmp path changes in each conversion.