pofider
commented
7 years ago Hi,
you are right. This requires extending this package. Don't you want to try to implement this and send PR?
- Extend the conversion function options parameter with
cookiesobject - Iterate over the object properties in the phantomjs script and call
addCookie - The unit test could simply just add cookie, write it to console.log and assert the correct value is in the output.
- Update readme
The PR would be basically the same as this one - https://github.com/pofider/phantom-html-to-pdf/pull/46/files You would probably only use object instead of array to pass cookies.
What you think?
chips5k
Hi, not sure where else to post this, but i need the ability to include a cookie when phantom js requests a file. I can see how i might do this by modifying your source code (which i'd rather not do), but i cannot work out where/how and in what format to supply cookies in the initial conversion function.
Below is the code i am using, i'd assumed i could just pass a cookies property in the options object. Tried several different formats, and tried to trace through your code but had no luck.
conversion({ url: request.post.location', // waitForJS: true, // waitForJSVarName: 'ready_to_print' }, function(err, pdf) { console.log(pdf.logs); console.log(pdf.numberOfPages); pdf.stream.pipe(response); });
Tried:
cookie: [[name, value]] cookie: [{name: name, value: value}] cookie: ["name=value"]
None of the above worked.
I've looked at phantomjs itself which recommends using addCookie methods, but since i dont have access to the phantom objects themselves, im not sure how to go about this (again without modifying the code).
thanks!
Callem.