search

pofider / phantom-html-to-pdf

Highly scalable html to pdf conversion using phantom workers
MIT License
159 stars 33 forks source link

fixed issue with race conditions when generating temp. pdf files; added option to specify the filename #75

Closed VinceG closed 7 years ago

VinceG commented 7 years ago

fixed issue with race conditions when generating temp. pdf files; added option to specify the filename

Issue: #76

bjrmatos commented 7 years ago

before merging, i will wait for @pofider comments, he probably has something to say about this change 😄

pofider commented 7 years ago

Thank you. I think that a benchmark is not so much important here since the pdf generation takes in every case billion times more than an uuid. If the v4 safer, it makes definitely sense to use it.

I don't see the tmpId option useful. But why not, if can give someone option to do something weird. :)

Thank you for contributing back.

VinceG commented 7 years ago

@pofider Thank You.