poggit-orphanage / FactionsPro

By Tethered
21 stars 69 forks source link

Faction Issue #10

Closed BajanVlogs closed 6 years ago

BajanVlogs commented 7 years ago

I have a issue with factionspro plugin when i do all the {fac_rank}{fac_name} all in the purechat then go ingame and reload then talk in chat it shows as {fac_rank}{fac_name} but when i make a faction it shows my fac name like DarkUnion but when i do /f del then it shows {fac_rank}{fac_name}

eqMFqfFd commented 7 years ago

@BajanVlogs Nametag will update once you relog. # ☆∂єvєlσρєя☆ кєνιи αи∂яєωѕ

EscherionPE commented 7 years ago

The thing is FactionsPro is not supposed to be the plugin to take care of player's nametags. We have PureChat for that job.

EscherionPE commented 7 years ago

but... to be honest I don't like how PureChat handles it as well

eqMFqfFd commented 7 years ago

@Panda843 It does not take care of player nametags. it translates the tags {} for displaying player information such as, the faction name.

EscherionPE commented 7 years ago

You didn't get what I meant. What I meant was there should be no code related to nametags in the FactionsPro plugin 'itself'. This is the reason why people have to relog to fix their tags, It is because both PureChat and FactionsPro themselves do something with the tags.

PureChat also has to take care of a player's nametag when that player joins or leaves a faction. Or when the faction gets disbanded, etc. FactionsPro should rely entirely on PureChat about the chat format / nametags. That is what PureChat is for, this is not something FactionsPro should do. Perhaps FactionLeaveEvent, FactionJoinEvent, FactionDisbandEvent will be of a good use...

eqMFqfFd commented 7 years ago

@Panda843 Understood. thanks for explaining! # ☆∂єvєlσρєя☆ кєνιи αи∂яєωѕ

nasiridrishi commented 7 years ago

comeon its working awesome with pure chat . there is no problems lol

Awzaw commented 6 years ago

Did anyone test the fix I made for this?

EscherionPE commented 6 years ago

No need to test. it is fine

EscherionPE commented 6 years ago

I tried to make something of my own, though. Take a look at this : http://github.com/Panda843/factionsZ. If someone can help me with optimizing stuff, add missing cmds, etc, possibly help me add support to PureChat too, it will be nice