poggit-orphanage / FactionsPro

By Tethered
21 stars 69 forks source link

f home #26

Closed nasiridrishi closed 6 years ago

nasiridrishi commented 6 years ago

f home set from previous plugin versions is not working with present version and throw error when command is ran:-

2017-11-21 [11:44:29] [Server thread/CRITICAL]: Unhandled exception executing command 'f home' in f: Argument 1 passed to pocketmine\Server::getLevelByName() must be of the type string, null given, called in phar:///home/fac/plugins/FactionsPro_dev-26.phar/src/FactionsPro/FactionCommands.php on line 726
2017-11-21 [11:44:29] [Server thread/CRITICAL]: TypeError: "Argument 1 passed to pocketmine\Server::getLevelByName() must be of the type string, null given, called in phar:///home/fac/plugins/FactionsPro_dev-26.phar/src/FactionsPro/FactionCommands.php on line 726" (EXCEPTION) in "src/pocketmine/Server" at line 961
2017-11-21 [11:44:29] [Server thread/DEBUG]: #0 FactionsPro_dev-26.phar/src/FactionsPro/FactionCommands(726): pocketmine\Server->getLevelByName(NULL )
2017-11-21 [11:44:29] [Server thread/DEBUG]: #1 FactionsPro_dev-26.phar/src/FactionsPro/FactionMain(108): FactionsPro\FactionCommands->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string f, array Array())
2017-11-21 [11:44:29] [Server thread/DEBUG]: #2 src/pocketmine/command/PluginCommand(58): FactionsPro\FactionMain->onCommand(pocketmine\Player object, pocketmine\command\PluginCommand object, string f, array Array())
2017-11-21 [11:44:29] [Server thread/DEBUG]: #3 src/pocketmine/command/SimpleCommandMap(258): pocketmine\command\PluginCommand->execute(pocketmine\Player object, string f, array Array())
2017-11-21 [11:44:29] [Server thread/DEBUG]: #4 src/pocketmine/Server(1979): pocketmine\command\SimpleCommandMap->dispatch(pocketmine\Player object, string f home)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #5 src/pocketmine/Player(2110): pocketmine\Server->dispatchCommand(pocketmine\Player object, string f home)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #6 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(220): pocketmine\Player->chat(string /f home)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #7 src/pocketmine/network/mcpe/protocol/CommandRequestPacket(47): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleCommandRequest(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #8 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\CommandRequestPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #9 src/pocketmine/network/mcpe/protocol/BatchPacket(115): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\CommandRequestPacket object)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #10 src/pocketmine/network/mcpe/PlayerNetworkSessionAdapter(92): pocketmine\network\mcpe\protocol\BatchPacket->handle(pocketmine\network\mcpe\PlayerNetworkSessionAdapter object)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #11 src/pocketmine/Player(2994): pocketmine\network\mcpe\PlayerNetworkSessionAdapter->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #12 src/pocketmine/network/mcpe/RakLibInterface(143): pocketmine\Player->handleDataPacket(pocketmine\network\mcpe\protocol\BatchPacket object)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #13 vendor/pmmp/raklib/server/ServerHandler(99): pocketmine\network\mcpe\RakLibInterface->handleEncapsulated(string 97.80.250.42:49182, raklib\protocol\EncapsulatedPacket object, integer 0)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #14 src/pocketmine/network/mcpe/RakLibInterface(84): raklib\server\ServerHandler->handlePacket()
2017-11-21 [11:44:29] [Server thread/DEBUG]: #15 src/pocketmine/network/Network(89): pocketmine\network\mcpe\RakLibInterface->process()
2017-11-21 [11:44:29] [Server thread/DEBUG]: #16 src/pocketmine/Server(2513): pocketmine\network\Network->processInterfaces()
2017-11-21 [11:44:29] [Server thread/DEBUG]: #17 src/pocketmine/Server(2269): pocketmine\Server->tick()
2017-11-21 [11:44:29] [Server thread/DEBUG]: #18 src/pocketmine/Server(2144): pocketmine\Server->tickProcessor()
2017-11-21 [11:44:29] [Server thread/DEBUG]: #19 src/pocketmine/Server(1734): pocketmine\Server->start()
2017-11-21 [11:44:29] [Server thread/DEBUG]: #20 src/pocketmine/PocketMine(550): pocketmine\Server->__construct(BaseClassLoader object, pocketmine\utils\MainLogger object, string phar:///home/fac/PocketMine-MP.phar/, string /home/fac/, string /home/fac/plugins/)
2017-11-21 [11:44:29] [Server thread/DEBUG]: #21 /home/fac/PocketMine-MP.phar(1): require(string phar:///home/fac/PocketMine-MP.phar/src/pocketmine/PocketMine.php)
Awzaw commented 6 years ago

Probably because faction 'Homes' now work properly, whereas before the home was saved with name but without the level name. A quick fix would be to delete all homes without a world entry in the database. I'll add a warning about this, and maybe update to delete such homes when found.

nasiridrishi commented 6 years ago

kk tnxs i will try that