poggit-orphanage / FactionsPro

By Tethered
21 stars 69 forks source link

Fix /f say #28

Closed Haxley closed 5 years ago

Haxley commented 6 years ago

Previously, the /f say conditional check disabled f say, probably because somebody planned to add a config line for it. Seems like that would be redundant so now if faction chat is enabled in config, so is /f say. Also moved /f say to "CHAT" section of command file instead of being in the "MEMBERS/OFFICERS/LEADER AND THEIR STATUSES" section

Haxley commented 6 years ago

Is there a reason this hasn't been merged yet? Right now the the f say disabled message conditional is set to true so /f say is always disabled.

                        if (true) {
                            $sender->sendMessage($this->plugin->formatMessage("/f say is disabled"));
                            return true;
                         }

and I changed to

            if (!$this->plugin->prefs->get("AllowChat")) {
                $sender->sendMessage($this->plugin->formatMessage("/f say is disabled"));
                return true;
            }
Awzaw commented 5 years ago

This was changed independently