https://timings.pmmp.io/?url=26268882

poggit-orphanage / FactionsPro

By Tethered

21 stars 69 forks source link

https://timings.pmmp.io/?url=26268882 #29

Closed BajanVlogs closed 6 years ago

BajanVlogs commented 6 years ago

Please take a look at this and maybe fix this

SOF3 commented 6 years ago

The database querying style definitely needs improvement, e.g. caching results. But this is quite a large change, and is probably out of scope of what @poggit-orphanage normally does (not that it shouldn't be done on poggit-orphanage, but this is not what we usually do).

Awzaw commented 6 years ago

The row: 0.13% 435.36% 0.87 s 217.68 ms 0.0 0.0k FactionsPro\FactionListener::onKill(PlayerDeathEvent)

Is not contributing significantly to your server load - it only happened 4 times during your 10 minutes sample, for a total of 4 * 217ms, i.e 0.87 s which comes out as a misleading 435 Pct Tick, but the Pct Total is only 0.13%. Still, it needs improving... I'll take a look.