search

poggit-orphanage / FactionsPro

By Tethered
21 stars 69 forks source link

Faction creation issue #49

Closed isoz closed 5 years ago

isoz commented 6 years ago

Factions can be created with the same name as long as capitalization is changed causing conflicts, for example:

Faction 1: Extreme Faction 2: ExtremE

SOF3 commented 6 years ago

The column should have COLLATE NOCASE

SOF3 commented 6 years ago

Currently, only player names have COLLATE NOCASE, but faction names don't. Can you describe some conflicts it is causing?

isoz commented 6 years ago

Well, in my case because I implemented a factions balance someone can create a faction with the same name and withdraw the money from the first one, which in this case is not entirely related but I'm sure there's interest in not having duplicate faction names. Thank you for your input.

SOF3 commented 6 years ago

Why don't you instead change how your factions balance work such that it won't conflict with multiple forms of the same name?

Awzaw commented 5 years ago

Finally fixed in 925f682fa7d1c