search

poggit-orphanage / FactionsPro

By Tethered
21 stars 69 forks source link

Update FactionCommands.php #6

Closed EscherionPE closed 7 years ago

EscherionPE commented 7 years ago

$invited is an instance of Player, but the function isInFaction() works with the name of the player (string) instead of the player object (Player) so it is $invited->getName().

By the way, wasn't I the one who created the modded versions and wasn't Primus the one who added /f map and even /f war? Why are you completely taking credit for something that isn't yours and publish it on poggit? ... You know that, despite the code of this plugin being pretty bad, we took from our time to add these features and you just straight copy-paste it without adding credits? I would understand if you didn't delete our names from /f about and submitted the plugin but... Should have at least put our names back in /f about or should have asked for permission...

Also remove all getNametag / setNametag / updateNametag methods/calls. PureChat is supposed to take care of that, not the FactionsPro plugin. This is also the reason why the nametags of the players that play in mcpe servers are often different because both PureChat and FactionsPro set nametags and this is where the confusion comes from.

Btw you are using 1.7.6. All the bugs you are going to encounter have already been fixed in 1.7.9 (the original versions)

Awzaw commented 7 years ago

Poggit-Orphanage exists to facilitate maintenance of abandoned plugins, and we take no credit for having written any of the plugins released. Or the mistakes. We would much rather the original authors remained active - it would be less work for us - but since often they aren't around we have to step in; not to take the credit for the code, but to provide a working plugin to users and ensure the authors work is respectfully maintained.

In this case Tethered is the original author (as credited), and there's no way of knowing who wrote any additional code; If some of it is yours or Primus', I'm sure the community is very grateful for your help, and what better reward is there than that?

https://github.com/poggit-orphanage/FactionsPro_1.4 is the most recent version that we could fork from Tethered's account since it is closed-source now, but if you are actively maintaining your own fork of FactionsPro then please do submit it on Poggit so we can remove both Poggit-Orphanage FactionsPro releases and let you take over.

SOF3 commented 7 years ago

An orphanage nurse never claims to be the real mother of an orphan :stuck_out_tongue:

EscherionPE commented 7 years ago

Well I am sorry about what I said. I beg you for an apology. I do not wish to takeover, I will simply help with prs whether it is needed :)