Improved exception error when .sql files are not preset in "resources" folder.

poggit / libasynql

Asynchronous MySQL access library for PocketMine plugins.

https://poggit.github.io/libasynql

Apache License 2.0

132 stars 44 forks source link

Closed matcracker closed 4 years ago

matcracker commented 4 years ago

How can it open a null resource stream? The getResource() already checks the file, if it exists will open the stream else not.

matcracker commented 4 years ago

I can move the condition inside the function, but in any case it can't generate a resource leak

SOF3 commented 4 years ago

getResource opens a new stream if possible. If it is non null, you are ignoring the stream.

SOF3 commented 4 years ago

Also please rebase on latest master. See the merge conflicts.

SOF3 commented 4 years ago

Please rebase from poggit:master, not to cherry-pick all your local changes to the old upstream.

matcracker commented 4 years ago

Done?