poggit / libasynql

Asynchronous MySQL access library for PocketMine plugins.
https://poggit.github.io/libasynql
Apache License 2.0
134 stars 44 forks source link

Use pmmp/Snooze instead of bare-usleeping #26

Closed CortexPE closed 4 years ago

CortexPE commented 4 years ago

Close #15 Close #22

This change also makes it so that mysqli connections are not pinged every 5 minutes, but only if the connection is dead before a query.

Some code refactoring might be needed in the future, but this contribution aims to be as less invasive / destructive as possible.

tnx @dktapps

lambuui commented 4 years ago

wut this, hurting me brain lol

dktapps commented 4 years ago

if you don't have something of value to add to the PR discussion, please don't bother to comment

SOF3 commented 4 years ago

I am not very familiar with the pthreads semantics nor Snooze, so I will let @dktapps decide whether this PR is ok to merge.