search

poggit / libasynql

Asynchronous MySQL access library for PocketMine plugins.
https://poggit.github.io/libasynql
Apache License 2.0
134 stars 44 forks source link

Server does not cascade shutdown or recover when SQL workers crash #71

Open SOF3 opened 2 years ago

SOF3 commented 2 years ago

Describe the bug A clear and concise description of what the bug is.

I accidentally changed the type of $queries for executeSelectRaw from list<string> to array{list<string>}. The query was serialized and unserialized in the worker send queue as-is, and only caused a crash when actually running in MysqliThread::executeQuery. This only crashes the worker thread, but the server keeps on running. If this happens in production scenario, all SQL workers will get stuck and all queries will end up taking forever to run, and server admin has no way to know what's wrong except by reading the crash output on the stdout, which does not even get sent to the PocketMine logger.

Environment hub.docker.com/pmmp/pocketmine-mp:4.0.2 OS: Ubuntu PocketMine version: 4.0.2

dktapps commented 2 years ago

If you're using Worker it won't actually crash, it'll just bork the task involved. https://github.com/pmmp/pthreads/issues/34

SOF3 commented 2 years ago

It isn't a worker. Just a thread on a wait loop.

Don't ask me why I didn't use a Worker.

dktapps commented 1 year ago

This will be fixed by the release of pmmpthread 6.0.0 (https://github.com/pmmp/ext-pmmpthread/commit/5c595c1504686e0cb6e8828fca1c752dafc85e5f)