poggit / libasynql

Asynchronous MySQL access library for PocketMine plugins.
https://poggit.github.io/libasynql
Apache License 2.0
132 stars 44 forks source link

Server crashes on PHP 8.1 due to not declaring return type of JsonSerializable::jsonSerialize() #87

Closed alvin0319 closed 1 year ago

alvin0319 commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

Fatal error: During inheritance of JsonSerializable: Uncaught ErrorException: Return type of poggit\libasynql\generic\GenericStatementImpl::jsonSerialize() should either be compatible with JsonSerializable::jsonSerialize(): mixe
d, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in C:\Users\minjae\Desktop\Projects\MCBE\MCBE\PocketMine-MP-Projects\CrushDev\virions\libasynql\src\poggit\libasynql\generic\GenericStatementImpl.php:246

Sample code N/A Expected behavior The server should not crash

Environment OS: Windows PocketMine version: 4.10.0 PHP: 8.1

SOF3 commented 1 year ago

please create a pull request.