search

pogzyb / asyncwhois

Python WHOIS and RDAP utility for querying and parsing information about Domains, IPv4s, IPv6s, and AS numbers
MIT License
63 stars 18 forks source link

Use enums for parser #16

Closed pogzyb closed 3 years ago

pogzyb commented 3 years ago

This PR implements a new class called "BaseKeys". It contains a standardized list of keys to be used across parsers. The keys within each parser were updated to match these. This change should help prevent "typos" or irregularities between future parser classes.

codecov[bot] commented 3 years ago

Codecov Report

Merging #16 (b091296) into master (71b0c56) will increase coverage by 1.38%. The diff coverage is 97.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
+ Coverage   75.68%   77.06%   +1.38%     
==========================================
  Files           6        6              
  Lines         987     1051      +64     
==========================================
+ Hits          747      810      +63     
- Misses        240      241       +1
Impacted Files Coverage Δ
asyncwhois/parser.py 73.37% <97.11%> (+2.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71b0c56...b091296. Read the comment docs.