search

pogzyb / asyncwhois

Python WHOIS and RDAP utility for querying and parsing information about Domains, IPv4s, IPv6s, and AS numbers
MIT License
63 stars 18 forks source link

Add code linter workflow #39

Closed pogzyb closed 2 years ago

pogzyb commented 2 years ago

Add black code-style linter that runs on each PR

rahulXs commented 2 years ago

Hey @pogzyb, Could you please tell me if the linter workflow using black should only detect the issue or it should also fix the code style violations automatically? Also taking reference to the build-and-test.yml workflow, Is it okay to use only a single runner for the linter workflow instead of matrix of agents kind because the black formatter would run the same way on all kind of runners? Please let me know. Thanks.

pogzyb commented 2 years ago

Hey @pogzyb, Could you please tell me if the linter workflow using black should only detect the issue or it should also fix the code style violations automatically? Also taking reference to the build-and-test.yml workflow, Is it okay to use only a single runner for the linter workflow instead of matrix of agents kind because the black formatter would run the same way on all kind of runners? Please let me know. Thanks.

Hi @rahulXs - Thanks for taking this on.

  1. If you can configure it to automatically fix formatting issues that would be awesome, but not a requirement, as long as it fails for lint issues is good for now.
  2. Yes, a single runner is preferred for this workflow.
rahulXs commented 2 years ago

@pogzyb - Thanks for the reply. I would work on it and raise the PR by tomorrow.