search

pogzyb / asyncwhois

Python WHOIS and RDAP utility for querying and parsing information about Domains, IPv4s, IPv6s, and AS numbers
MIT License
63 stars 18 forks source link

Make timeout behavior more consistent #55

Closed BlindingRadiance closed 1 year ago

BlindingRadiance commented 1 year ago

Hi!

I've noticed that in some cases waiting for _aio_send_and_recv might take a lot of time since it doesn't have any sort of timeout checks. So I've tried to fix that and make proxy connections also set the specified timeout.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 33.33% and no project coverage change.

Comparison is base (c281a6c) 88.88% compared to head (890f6bc) 88.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #55 +/- ## ======================================= Coverage 88.88% 88.88% ======================================= Files 8 8 Lines 2815 2815 ======================================= Hits 2502 2502 Misses 313 313 ``` | [Impacted Files](https://codecov.io/gh/pogzyb/asyncwhois/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joe) | Coverage Δ | | |---|---|---| | [asyncwhois/query.py](https://codecov.io/gh/pogzyb/asyncwhois/pull/55?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joe#diff-YXN5bmN3aG9pcy9xdWVyeS5weQ==) | `80.53% <33.33%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Joe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pogzyb commented 1 year ago

Ah yeah I've been bitten by this timeout inconsistency at work before when trying use to make the query connect go through the corporate proxy. This is definitely a great find and thanks so much for putting together a PR too.

Rubikoid commented 1 year ago

@pogzyb, hi!

Thank you for accepting PR so fast!

So, can you please make new release with the last two merges? It will be great.

pogzyb commented 1 year ago

@pogzyb, hi!

Thank you for accepting PR so fast!

So, can you please make new release with the last two merges? It will be great.

Sorry for the delay! 1.0.5 is released.