search

pohutukawa-2022 / gardenz

Empowering community gardens in New Zealand
0 stars 0 forks source link

Consistent Promise Handling - async / await: Batch 3 #33

Open alexcoaton opened 2 years ago

alexcoaton commented 2 years ago

There are over 150 uses of .then() in the codebase at the time of this issue creation. The objective is to eventually get them all converted to a single consistent style with async...await, instead, but it would be impractical to do them all at once.

Note that there is one exception where async / await can be problematic - inside useEffect() hook calls. Read this blog post to find out how to handle it correctly.

Considering the above exception, find uses of .then() in the following files and replace them with async / await-style promise handling.

image

Bryden-Gunn commented 2 years ago

Being reviewed by Vanessa and Bryden

alexcoaton commented 2 years ago

PR https://github.com/pohutukawa-2022/gardenz/pull/43

EliseWei commented 2 years ago

I don't see that any changes have been made since the last review, so I don't think this is ready for re-review? Putting back to in-progress.

rongyue1 commented 2 years ago

Removed console.log and refactored try-catch block from Alex comment

rongyue1 commented 2 years ago

One more try, this time we've checked the last commit has no console log and run lint was ok (8 warnings)

rongyue1 commented 2 years ago

Added env.example back