Closed livikavesi closed 2 years ago
Hallo, @livikavesi @Luke-vanKan @henrytake2, if this is ready for teacher code review, could you do a couple things please?
1) tick all the items in the PR template that have been completed. This should include the linter, manual testing, and creation of a PR, at least 🙃 2) for peer reviews, can you get at least one of your reviewers to "Approve" the PR here in github? It looks like this:
I can start taking a look at this, in the meantime, though. Thanks!
Have removed the duplicate :)
One unresolved question from code review as well as the request to please tick off items in Definition of Done and get your peer reviewer to "Approve"
And good work on the fix!
Definition of Done
For every submission to the codebase, check that it meets the DoD below.