mcdon-ron commented 12 years ago

I suggest defining a [Main] section of the WinRun4J ini file. The actual name is not as important as some name being defined. This section would contain the ini entries that are currently defined without a section from "working.directory" to "ini.override".

The reason for my request is that I had an issue deploying the WinRun4J ini file using Windows Installer (Wix specifically). Windows Installer has an error "Error 2109: Section missing for INI action" when attempting to write an ini value without a section defined or empty (http://msdn.microsoft.com/en-us/library/windows/desktop/aa372835(v=vs.85).aspx). I was trying to write the WinRun4J ini file using Wix's IniFile Element (http://wix.sourceforge.net/manual-wix3/wix_xsd_inifile.htm). Wix's IniFile element is in short a wrapper around Windows Installers IniFile Table (http://msdn.microsoft.com/library/aa369282.aspx).

For this change the Ini keys may be defined like:

// Ini keys

define WORKING_DIR "Main:working.directory"

define LOG_FILE "Main:log"

define LOG_LEVEL "Main:log.level"

define CLASS_PATH "Main:classpath"

define VM_ARG "Main:vmarg"

define PROG_ARG "Main:arg"

define MAIN_CLASS "Main:main.class"

define SERVICE_CLASS "Main:service.class"

poidasmith commented 12 years ago

Thanks for the feedback. This sounds reasonable I would probably use [WinRun4J] as the section but keep it backward compatible (look in this section first and then check default section).