poingstudios / godot-admob-android

Godot's AdMob Plugin for Android with support for Mediations.
https://poingstudios.github.io/godot-admob-plugin/
MIT License
303 stars 32 forks source link

Update for godot 4.2.0 stable #211

Closed LotusLegends closed 5 months ago

LotusLegends commented 5 months ago

Is your feature request related to a problem? If so, please describe.

Add admob support for godot 4.2.0 stable.

What feature or improvement would you like to see?

Add admob support for godot 4.2.0 stable.

Additional context

No response

gumaciel commented 5 months ago

Hi, the plugin already has support for 4.2, are you facing some error?

FabPei commented 5 months ago

Not the same game, but i was confused because no "plugins" folder was created in the projects "android" folder. Did that change with 4.2 and the new Android V2 plugin system?

gumaciel commented 5 months ago

It shouldn't, if it doesn't exist, try creating a folder, I'll look into that

gumaciel commented 5 months ago

@FabPei Yeah, doesn't exist anymore due v2 Android plugin system.

But you only need to create a folder "plugin" and then add the plugin binaries and then it will work Screenshot 2023-12-17 at 10 24 34

Closing this issue since it's working for v4.2+

FabPei commented 5 months ago

Hi, yeah it definitely works by just creating a folder, was rather confused before trying the plugin because i thought it doesnt work anyway due the 4.2 change and the missing folder. Thanks!

LotusLegends commented 5 months ago

@FabPei Yeah, doesn't exist anymore due v2 Android plugin system.

But you only need to create a folder "plugin" and then add the plugin binaries and then it will work Screenshot 2023-12-17 at 10 24 34

Closing this issue since it's working for v4.2+

Bro this work for you?, you can give me exported apk file?

FabPei commented 5 months ago

@LotusLegends it works in 4.2. I just followed the instructions