poingstudios / godot-admob-ios

Godot's AdMob Plugin for iOS with support for Mediations.
https://poingstudios.github.io/godot-admob-plugin/
MIT License
89 stars 14 forks source link

fix(rewarded-ad): wrong signal when load ad failed #10

Closed kyoz closed 2 years ago

kyoz commented 2 years ago

This fix wrong signal fire when reward ad failed to load.

gumaciel commented 2 years ago

Thank you so much!

As I can see your change is correct, I will just test it in a few hours and approve if works.

kyoz commented 2 years ago

Yes, i just randomly figure it out when i use a toast to show "No video available" and without the fix, when turn the internet off and open the app. The toast just popup crazily. kk

gumaciel commented 2 years ago

Thank you, this should be fixed at #4 but was strangely unresolved