search

poingstudios / godot-admob-ios

Godot's AdMob Plugin for iOS with support for Mediations.
https://poingstudios.github.io/godot-admob-plugin/
MIT License
108 stars 16 forks source link

[BUG] Incorrect signal being emitted in v2 #105

Open WolfgangSenff opened 2 months ago

WolfgangSenff commented 2 months ago

Godot version

3.5.3

Plugin version

v2.1.0

Phone information

All iOS devices

Issue description

When the GAD delegate calls to https://developers.google.com/admob/ios/api/reference/Protocols/GADFullScreenContentDelegate#-ad:didfailtopresentfullscreencontentwitherror:, the plugin fires the interstitial_failed_to_load signal. However, because it's attempting to present it, it should be interstitial_failed_to_show. This is of course in an older version, but is a simple fix, and I'm happy to open a PR for it, just can't at the moment due to having to find a work-around for this in my app.

Steps to reproduce

The issue is right here: https://github.com/poingstudios/godot-admob-ios/blob/4ceb5f9944b9d6cad6ae76e54cd5451e1cc04b6a/plugin/admob/src/formats/Interstitial.mm#L87

Further, you can see that it's probably not intended to be load by looking at this line, which is firing the same signal, but correctly from the load call: https://github.com/poingstudios/godot-admob-ios/blob/4ceb5f9944b9d6cad6ae76e54cd5451e1cc04b6a/plugin/admob/src/formats/Interstitial.mm#L50

Additional context

If you're willing to make a new release and don't have time to fix this yourself, I'm happy to open a PR. Let me know!

gumaciel commented 2 months ago

Thank you for opening this issue, It would be awesome if you open a PR!