poingstudios / godot-admob-ios

Godot's AdMob Plugin for iOS with support for Mediations.
https://poingstudios.github.io/godot-admob-plugin/
MIT License
89 stars 14 forks source link

Remove `tag name` parameter from GitHub Actions #50

Open gumaciel opened 11 months ago

gumaciel commented 11 months ago

Is your feature request related to a problem? Please describe. Currently, when running a GitHub Action, you need to specify the tag name as a parameter. This is unnecessary, as the tag name is already selected when you run the Action.

Describe the solution you'd like I would like to request that the tag name parameter be removed from GitHub Actions. This would make it easier to run Actions and would also reduce the number of parameters that need to be specified.

Additional context

nsundriyal62 commented 10 months ago

can you please elborate it more ............ like soution and approach i think i can solve this out

gumaciel commented 10 months ago

@nsundriyal62 thank you very much for your interest in collaborating, we really need it

The idea is as follows: Today we have a workflow called manual_release_ios.yml, you can see code and the usage here: https://github.com/Poing-Studios/godot-admob-ios/actions/runs/5862833398/workflow

This workflow has an input called tag, which is responsible for passing the version to perform the build (for example: v3.0.0)

The idea is to remove this entry and just use the Use workflow from value using the version number:

Screenshot 2023-08-29 at 08 13 08

Maybe this helps: https://github.com/orgs/community/discussions/26686#discussioncomment-3252852

Or maybe this echo ::set-output name=SOURCE_TAG::${GITHUB_REF#refs/tags/}

gumaciel commented 10 months ago

If possible also try for Android, it's the same behavior: https://github.com/Poing-Studios/godot-admob-android/actions/runs/5767406158/workflow