search

poingstudios / godot-admob-ios

Godot's AdMob Plugin for iOS with support for Mediations.
https://poingstudios.github.io/godot-admob-plugin/
MIT License
89 stars 14 forks source link

fix: consent information status code #77

Closed hortopan closed 6 months ago

hortopan commented 7 months ago

iOS UMPConsentStatus status = [UMPConsentInformation.sharedInstance consentStatus]; ENUM differs from the android version which creates an issue when checking for consent status and resulting in form not being shown on iOS in some cases.

More specifically, on [IOS]:(https://developers.google.com/admob/android/privacy/api/reference/com/google/android/ump/ConsentInformation.ConsentStatus)

UMPConsentStatusUnknown = 0 UMPConsentStatusRequired = 1 UMPConsentStatusNotRequired = 2 UMPConsentStatusObtained = 3

while on Android

UNKNOWN = 0 NOT_REQUIRED = 1 REQUIRED = 2 OBTAINED = 3

We could either fix this here or do a fix in the admob gdscript side of things, but I believe this would be cleaner.

gumaciel commented 6 months ago

thank you so much for this fix!

hortopan commented 6 months ago

Thank you for a great plugin!