poingstudios / godot-admob-plugin

This repository is for Godot's Addons to integrate natively AdMob to your Game Project without much configurations and directly inside Godot Editor!
https://poingstudios.github.io/godot-admob-plugin/
MIT License
312 stars 22 forks source link

Import error #131

Open wozpi opened 9 months ago

wozpi commented 9 months ago

Godot version

v4.2.1

Plugin version

v3.1.0

System information

MacOS 14.1.2 (23B92)

Phone information, if applicable

No response

Issue description

Parser Error: Invalid argument for "new()" function: argument 2 should be "State" but is "AdapterStatus.State".

Steps to reproduce

Download and import from github or asset have error Parser Error: Invalid argument for "new()" function: argument 2 should be "State" but is "AdapterStatus.State".

Screenshot 2023-12-31 at 22 03 13

Additional context

No response

gumaciel commented 9 months ago

Thank you for opening this issue, we will investigate

wozpi commented 9 months ago

i fixed for temp 🧛

Screenshot 2023-12-31 at 22 07 58
ZachBeauchamp commented 4 months ago

i fixed for temp 🧛 Screenshot 2023-12-31 at 22 07 58

image

I am getting an error when trying to use your fix. Using the latest version of Godot.

gumaciel commented 4 months ago

hi @ZachBeauchamp are you trying on iOS or Android?

ZachBeauchamp commented 4 months ago

hi @ZachBeauchamp are you trying on iOS or Android?

Hi, I am trying to use it for Android.

ZachBeauchamp commented 4 months ago

I was able to fix it. I removed the ": AdapterStatues.State" assertion. Thanks to user "Arcana" on the godot discord server. image

gumaciel commented 4 months ago

@ZachBeauchamp and @wozpi were you guys testing on iOS or Android?

gumaciel commented 4 months ago

@ZachBeauchamp @wozpi I can't reproduce either in Android or iOS :(

Can you guys please try again in Godot 4.2.2?

ZachBeauchamp commented 4 months ago

@ZachBeauchamp @wozpi I can't reproduce either in Android or iOS :(

  • The change in @wozpi is more appropriate but it's the "same thing" as before and shouldn't break the code.

Can you guys please try again in Godot 4.2.2?

Check to see if the the fix I offered is just automatically in your version. For some other people I have talked to it was.

gumaciel commented 4 months ago

I will close this issue since I did not reproduce it and it seems fixed by you.

If someone still has this problem please re-open it.

gumaciel commented 3 weeks ago

Stills happens when some class in the project has the same name as State