search

poingstudios / godot-admob-plugin

This repository is for Godot's Addons to integrate natively AdMob to your Game Project without much configurations and directly inside Godot Editor!
https://poingstudios.github.io/godot-admob-plugin/
MIT License
276 stars 22 forks source link

ConsentInformation.update callbacks are called repeatedly #134

Closed abcjjy closed 1 month ago

abcjjy commented 4 months ago

Godot version

4.2

Plugin version

3.1.0

System information

Godot v4.2.stable - macOS 13.6.1 - GLES3 (Compatibility) - ANGLE (AMD, ANGLE Metal Renderer: AMD Radeon Pro 560X, 版本13.6.1（版号22G313）) - Intel(R) Core(TM) i7-8850H CPU @ 2.60GHz (12 Threads)

Phone information, if applicable

iPhone X iOS 14.8

Issue description

Each time ConsentInformation.update is called, new callbacks are connected to the inner signals. In later call to update(), previous callbacks are also fired.

An option is passing Callables into native plugin instead of using signals.

UserMessagingPlatform.load_consent_form has similar issues too.

Steps to reproduce

Call ConsentInformation.update multiple times, all the used callbacks are called.

Additional context

No response

gumaciel commented 3 months ago

thank you for opening this issue, i will verify this

gumaciel commented 1 month ago

@abcjjy fixed at https://github.com/poingstudios/godot-admob-plugin/releases/tag/v3.1.1, please test it