search

point85 / OEE-Designer

The OEE-Designer is the build time environment for OEE applications.
MIT License
93 stars 46 forks source link

Java paths with spaces won't work on Windows (*.bat files) #15

Closed gregid closed 2 years ago

gregid commented 2 years ago

None of the *.bat files will work if the %JAVA_HOME% and %JAVAFX_HOME% paths include spaces on Windows (e.g. most common C:\Program Files\JAVAHOME\)

The error will be System Windows cannot find C:\Program

These paths should be wrapped in double quotes.

point85 commented 2 years ago

The cleanest generic option is to use the system environment variable JAVA_HOME pointing to the bin folder. Then in the batch files just "start javaw.exe". If you have another location, just put the full path in the .bat files.

gregid commented 2 years ago

In case you would decide to change *.bat files to also work with more problematic paths here is where the double quotes should be:

start "" "%JAVA_HOME%bin\javaw.exe" -p "%JAVAFX_HOME%\lib" --add-modules javafx.controls,javafx.fxml,javafx.web -Dlog4j.configurationFile=config\logging\log4j2.xml -jar oee-apps-3.7.0.jar DESIGNER jdbc:hsqldb:hsql://localhost/OEE SA

The empty "" is required for cmd window title when double quotes are used.

gregid commented 2 years ago

With the changes in commit: https://github.com/point85/OEE-Designer/commit/d905065cbd3bc71084b47effc9e5b967616152a9

It would still fail if %JAVAFX_HOME% contain spaces

point85 commented 2 years ago

Thanks gregid. I updated the Wiindows batch files accordingly

On Sat, Jul 9, 2022 at 3:51 AM gregid @.***> wrote:

With the changes in commit: d905065 https://github.com/point85/OEE-Designer/commit/d905065cbd3bc71084b47effc9e5b967616152a9

It would still fail if %JAVAFX_HOME% contain spaces

— Reply to this email directly, view it on GitHub https://github.com/point85/OEE-Designer/issues/15#issuecomment-1179523141, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC6MX4B5O43DRWRBPZGBQITVTFKUFANCNFSM53CFUVVA . You are receiving this because you modified the open/close state.Message ID: @.***>