Closed MatthewYu06 closed 1 year ago
Overall the homework took me around 2 hours (including the optional parts). I have a couple of comments
I like the first set of optional exercises, but they make the main part of the homework feel repetitive and samey (which is not necessarily a bad thing, just something to keep in mind).
Okay -- looks like my previous comment doesn't exactly have any serious conflicts with my newly updated thoughts on things; so, I'll start pretty fresh here about what I'm thinking (having not yet had any sort of look at any revisions you may have made to the HW).
Fisher_p_values.ipynb
Fisher_p_values.ipynb
, then; and, we'll need example answers for all the questions that are automatically failed tests so that they show up as feedback for the student who review answers through MarkUs. Fisher_p_values.ipynb
so that you could put some fresh eyes on it and catch anything weird in there that I'm missing... please be openminded in your review of that file in the event that you see further opportunities for improvements in the exercise that might better student experience with this notebook.I've also made some decisions about what we should do with the tutorial for week 5.
Fisher_p_values.ipynb
: we don't want this to take a lot of time for the TA; but, we want to touch on it so that it's not too weird in the students homework exerciseFisher_p_values.ipynb
. I'm not saying things here are "wrong" (as I honestly haven't looked at this very closely at this point); instead, just that we've gotta be very streamlined with showing the theoretical binomial distribution for this problem and producing a p-value from it, and then showing the distribution that the t-test uses to compute its p-value. Wherever you think your material helps/supports this then let's put it in; but, the point of having all of this is to show repeat the "as or more extreme" p-value exercise; and, show that different kinds of p-values exist. It's possible the exposition you've created so far indeed has the correct home in the tutorial slides; or, perhaps it might fit nicely into Fisher_p_values.ipynb
as additional helpful explanation information there.Ready for Review I'll try to make assignments on MarkUs soon to test out autotesting
Currently worked on files:
Homework_5_student_4.ipynb
/Homework_5_tester_4.ipynb
Fisher_p_values.ipynb
/Fisher_p_values_student.ipynb
Tutorial_5_draft_2.ipynb
Homework:
Tutorial Slides:
Fisher_p_values.ipynb
in case student wants more exposureTutorial Assignment:
Homework and tester were in good shape as far as I could tell (with the exception of Q13 which needed a good amount of work in my view). My review and edits are below (please review/confirm, Matthew); and, they were mostly pretty easy to do with everything here mostly already in pretty good shape at this point in time.
simulated_sample_n400
as this would lose the student information
"Your p-value should be "+str(p_value)+" according to the code below; but, "
can be used to expose answer information that might help explain to students what exactly is going wrong with their answer (so they can troubleshoot it for us, especially if something's not working on our end); and, here, of course, we do actually need to run the code (so we have these answers) as well as formatting it for output assert
statement based on assert p_value == test_p_value
is not going to work as it should be Q13
(although Q14
"worked" because you did there assign p_value
a value)
p
is the right choice as this refers to a proportion, but you've not structured your answer in terms of proportions (which I actually think is quite nice/good, btw).Didn't catch anything new that needed to be addressed in the remainder of the questions Q15-19: hopefully indeed they're okay at this point
Going to try these out in MarkUs now :)
I needed to make a few edits.
simulated_samples,n = 1000
: fixed this upCaught a couple more errors, e.g.,
\\text
instead of \text
TUT
Homework:
Fisher:
I've gone ahead and removed Q13/Q14 -- contents there are still available in commit history; so/and, it could be repurposes for the tutorial next week.
Everything else looked in good shape with the edits I've made just being the usual kinds of things I see upon re-review.
Very pleased with the fisher homework for the tutorial.
So now I just need to update the tutorial assignment to point to the fisher exercise... will do tomorrow first thing I think.
And now we're just waiting for one more review from @mistryrohan of the Homework; and, let's also have Rohan review the Fisher notebook as well. And that should finalize everything here!
@mistryrohan if the folders aren't sorted by the time you are ready to review, the files to review are:
Homework: Homework_5_tester_4.ipynb
, Homework_5_student_4.ipynb
Tutorial: Tutorial_5_draft_2.ipynb
Fisher: Fisher_p_values.ipynb
, Fisher_p_values_student.ipynb
Otherwise just review whats there
Oops -- did not describe that right:
As per Slack messages I have sent all the edited files to Matthew, do not know if there are issues with now my edits + Scott's new commits. If that is the case, I am happy to go over the files once more and make the same changes.
Hey @MatthewYu06 -- there is not Homework_5_student_4.ipynb
; instead, you've renamed it Homework_5_student_4._ipynb
.
Actually, this is not the way we should be doing this. You want to make edits on the same filename so that all changes can be observed and tracked. When you just delete Homework_5_student_4.ipynb
and (then make some changes?) and replace it with the different file Homework_5_student_4._ipynb
all change tracking done by git IS LOST!
Do you see what I mean?
Edit files directly. File renaming should be done itself with git mv file_old.name file_new.name
and is it self a new commit. I am demonstrating this with my last few commits.
Hey @mistryrohan and @MatthewYu06 -- it sounds like edits are not being made as commits directly into the PR as I have been doing. This means we'll have potential conflicts.
@mistryrohan I'm not sure what slack messages you're referring to: DMs with Matthew? I thought our messages were about figuring out how to make direct commits to PRs?
Homework_5_student_4._ipynb
new file creation?Final final naming update for @mistryrohan re: @MatthewYu06 (https://github.com/pointOfive/STA130_F23/pull/16#issuecomment-1614014783, etc.)
@pointOfive These were sent before your renaming of the files. Also, I am refering to Slack direct messages from last night in response to yours (sorry for not specifying). I got the ssh key onto my account but still cannot clone it. Commands like clip, clip.exe, others from your instructions, and more do not seem to work. Cloning still asks for a public key (even though it is there now) and it was taking hours figuring it out so to not create more backlog I just sent changes to Matthew to commit on my behalf.
Edit: If the only changes now were just file renaming there should be no conflicts when Matthew pushes my changes
Oh sorry -- it seems slack was not delivering me messages... hmm... let me have a look at things and catch up! Will move the conversation over there as it might be a little smoother than here if it's working again.
Thanks for waiting, I included sample solutions in the homework labelled "SAMPLE SOLUTION" I had some concerns while making the homework and tutorial: Homework:
Tutorial: