pointOfive / STA130_F23

Python/JupyterHub implementation of this UofT classic
10 stars 14 forks source link

Homework and Tutorial 5 #16

Closed MatthewYu06 closed 1 year ago

MatthewYu06 commented 1 year ago

Thanks for waiting, I included sample solutions in the homework labelled "SAMPLE SOLUTION" I had some concerns while making the homework and tutorial: Homework:

Tutorial:

Bortoise commented 1 year ago

Overall the homework took me around 2 hours (including the optional parts). I have a couple of comments

  1. p is not defined in the warm up, it's clear from context that p is the proportion of students who use twitter, however it might be worthwhile to say so explicitly.
  2. You should be able to have the autograding handle Q4 pretty easily.

I like the first set of optional exercises, but they make the main part of the homework feel repetitive and samey (which is not necessarily a bad thing, just something to keep in mind).

pointOfive commented 1 year ago

Okay -- looks like my previous comment doesn't exactly have any serious conflicts with my newly updated thoughts on things; so, I'll start pretty fresh here about what I'm thinking (having not yet had any sort of look at any revisions you may have made to the HW).

I've also made some decisions about what we should do with the tutorial for week 5.

MatthewYu06 commented 1 year ago

Ready for Review I'll try to make assignments on MarkUs soon to test out autotesting

Currently worked on files:

Homework:

Tutorial Slides:

Tutorial Assignment:

pointOfive commented 1 year ago

Homework and tester were in good shape as far as I could tell (with the exception of Q13 which needed a good amount of work in my view). My review and edits are below (please review/confirm, Matthew); and, they were mostly pretty easy to do with everything here mostly already in pretty good shape at this point in time.

Didn't catch anything new that needed to be addressed in the remainder of the questions Q15-19: hopefully indeed they're okay at this point

Going to try these out in MarkUs now :)

pointOfive commented 1 year ago

I needed to make a few edits.

pointOfive commented 1 year ago

Caught a couple more errors, e.g.,

pointOfive commented 1 year ago

TUT

MatthewYu06 commented 1 year ago

Homework:

MatthewYu06 commented 1 year ago

Fisher:

pointOfive commented 1 year ago

I've gone ahead and removed Q13/Q14 -- contents there are still available in commit history; so/and, it could be repurposes for the tutorial next week.

Everything else looked in good shape with the edits I've made just being the usual kinds of things I see upon re-review.

Very pleased with the fisher homework for the tutorial.

pointOfive commented 1 year ago

So now I just need to update the tutorial assignment to point to the fisher exercise... will do tomorrow first thing I think.

pointOfive commented 1 year ago

And now we're just waiting for one more review from @mistryrohan of the Homework; and, let's also have Rohan review the Fisher notebook as well. And that should finalize everything here!

MatthewYu06 commented 1 year ago

@mistryrohan if the folders aren't sorted by the time you are ready to review, the files to review are: Homework: Homework_5_tester_4.ipynb, Homework_5_student_4.ipynb Tutorial: Tutorial_5_draft_2.ipynb Fisher: Fisher_p_values.ipynb, Fisher_p_values_student.ipynb

Otherwise just review whats there

pointOfive commented 1 year ago

Oops -- did not describe that right:

mistryrohan commented 1 year ago

As per Slack messages I have sent all the edited files to Matthew, do not know if there are issues with now my edits + Scott's new commits. If that is the case, I am happy to go over the files once more and make the same changes.

pointOfive commented 1 year ago

Hey @MatthewYu06 -- there is not Homework_5_student_4.ipynb; instead, you've renamed it Homework_5_student_4._ipynb.

Actually, this is not the way we should be doing this. You want to make edits on the same filename so that all changes can be observed and tracked. When you just delete Homework_5_student_4.ipynb and (then make some changes?) and replace it with the different file Homework_5_student_4._ipynb all change tracking done by git IS LOST!

Do you see what I mean?

Edit files directly. File renaming should be done itself with git mv file_old.name file_new.name and is it self a new commit. I am demonstrating this with my last few commits.

pointOfive commented 1 year ago

Hey @mistryrohan and @MatthewYu06 -- it sounds like edits are not being made as commits directly into the PR as I have been doing. This means we'll have potential conflicts.

pointOfive commented 1 year ago

@mistryrohan I'm not sure what slack messages you're referring to: DMs with Matthew? I thought our messages were about figuring out how to make direct commits to PRs?

pointOfive commented 1 year ago

Final final naming update for @mistryrohan re: @MatthewYu06 (https://github.com/pointOfive/STA130_F23/pull/16#issuecomment-1614014783, etc.)

mistryrohan commented 1 year ago

@pointOfive These were sent before your renaming of the files. Also, I am refering to Slack direct messages from last night in response to yours (sorry for not specifying). I got the ssh key onto my account but still cannot clone it. Commands like clip, clip.exe, others from your instructions, and more do not seem to work. Cloning still asks for a public key (even though it is there now) and it was taking hours figuring it out so to not create more backlog I just sent changes to Matthew to commit on my behalf.

Edit: If the only changes now were just file renaming there should be no conflicts when Matthew pushes my changes

pointOfive commented 1 year ago

Oh sorry -- it seems slack was not delivering me messages... hmm... let me have a look at things and catch up! Will move the conversation over there as it might be a little smoother than here if it's working again.