pointOfive / STA130_F23

Python/JupyterHub implementation of this UofT classic
10 stars 14 forks source link

Markus HW2 Automated Testing Unavailable On Student View + Potential Broken Tests #7

Closed mistryrohan closed 1 year ago

mistryrohan commented 1 year ago
  1. On the student view after submitting Homework 2, I am unable to see the automated testing option but on the Instructor View the file does seem to be there but I do not know how to make it visible on the student end

But I did have the previous solution file (with the asserts) downloaded before the new HW2 was committed and found 2 potential issues:

  1. On Test 5 it is assert Q5 == 0.692, "Try (d[(d.Age>=25)&(d.Age<=40)].Survived=='Dead').mean()"

The solution is 0.6925960637300843 so we should be asserting 0.693

  1. On Test 6 it is assert Q6 == (0.700, .032, 0.539), 'Try (d.Survived[d.Paid>50]=="Dead").groupby(d.Man_Woman_or_Child).mean()'

The value for children is 0.538462 so we should be asserting (0.700, .032, 0.538)

lucieyang1 commented 1 year ago

For Q6, why would it be 0.538? I assumed "provide 3 decimal places rounding up" means to round the last place to the next highest one, no matter the following digits.

mistryrohan commented 1 year ago

Also a fair point I guess it's just how you interpret it. I was thinking it meant round up if like 1.234x if x >= 5

pointOfive commented 1 year ago

Found the issue with why student tests weren't available: the "Tokens available on" in the automated settings was set to a date in the future...

I'll look into the other issues momentarily.

pointOfive commented 1 year ago

So we'll go with rounding as provided by np.round. This will show in the errors if students get it wrong, and they can correct it if they wish at that point; although, the TAs shouldn't be marking off points based on smaller errors like this.

commit/c489b71