search

pointbiz / bitaddress.org

JavaScript Client-Side Bitcoin Wallet Generator
https://www.bitaddress.org
2.44k stars 1.5k forks source link

Incorrect number of BIP38 Paper Wallets generated in Firefox #61

Open anaoum opened 10 years ago

anaoum commented 10 years ago

Tested in Firefox 23.0 on Ubuntu 12.04.3 and Firefox 25.0.1 on Mac OS X 10.9.1.

Steps to reproduce:

  1. Completely reload page
  2. Click on Paper Wallet tab
  3. Check Hide Art box
  4. Check BIP38 Encrypt
  5. Enter password 'a' (anything should work)
  6. Enter '100' in Addresses to Generate
  7. Click generate

Expected output:

100 paper wallets with unique addresses and keys

Actual output:

Around half of the wallets are completely blank (no QR codes or address or encrypted private keys). The number of blank wallets varies with each run.

Other notes:

It appears it may have something to do with the async callback being called too early. When experimenting with a smaller number of wallets to generate (say 25), I get a similar result with the bottom few wallets being empty, but after about 30 seconds, they sometimes will populate themselves. With a large number of wallets (around 100), the bottom half never gets populated no matter how long I wait.

This problem only seems to happen when I select Hide Art.

anaoum commented 10 years ago

I have also verified this on Firefox 26.0 on Mac OS X 10.9.1.

anaoum commented 10 years ago

I have also been able to reproduce this with a small number of wallets (7) by repeating steps 2 through 7 multiple times. The first time, it will generate all 7 wallets, but subsequent times will leave blank wallets.

pointbiz commented 10 years ago

I also see this on Firefox 26 on Windows 7

pointbiz commented 10 years ago

I waited a long time and the addresses did show up on Firefox 26 on Windows 7. At least when I was generating 21 addresses.