On subpage Walletdetails, show only QR code for private key BIP38 format - if this was provided by the user

pointbiz / bitaddress.org

JavaScript Client-Side Bitcoin Wallet Generator

https://www.bitaddress.org

2.45k stars 1.51k forks source link

On subpage Walletdetails, show only QR code for private key BIP38 format - if this was provided by the user #80

Closed Wikinaut closed 9 years ago

Wikinaut commented 10 years ago

I suggest to show only the QR code for the password-protected private key in BIP38 format, if such a key was the input.

Rationale:

Don't show the unprotected private keys as QR codes unless this is absolutely needed. If the user supplied a BIP38 key and the password as input, it is not necessary to generate QR codes for the unprotected keys.

pointbiz commented 10 years ago

I'm not sure your rationale covers all use cases.