search

pointfreeco / composable-core-location

A library that bridges the Composable Architecture and Core Location.
MIT License
110 stars 55 forks source link

Fix release build #15

Closed andreyz closed 3 years ago

andreyz commented 3 years ago

Should fix #14

mbrandonw commented 3 years ago

This shouldn't be necessary because we provide a stubbed implemented of XCTFail in non-debug builds:

https://github.com/pointfreeco/xctest-dynamic-overlay/blob/0ec2d710978df8a73ae788b9897d2c189880de0f/Sources/XCTestDynamicOverlay/XCTFail.swift#L74-L94

That was released in 0.2.0 of xctest-dynamic-overlay. I believe if you update your packages to their latest versions it should work fine.

We could do a better job of forcing SPM to pull in 0.2.0 of cutest-dynamic-overlay by pinning the TCA version in the library to 0.25.0, which is when TCA bumped to 0.2.0.

What do you think about making that change instead?

andreyz commented 3 years ago

We could do a better job of forcing SPM to pull in 0.2.0 of cutest-dynamic-overlay by pinning the TCA version in the library to 0.25.0, which is when TCA bumped to 0.2.0.

What do you think about making that change instead?

@mbrandonw sounds good!