pointfreeco / composable-core-location

A library that bridges the Composable Architecture and Core Location.
MIT License
107 stars 56 forks source link

The reason public initialiser isn't available for LocationManager? #17

Closed andreyz closed 2 years ago

andreyz commented 2 years ago

It's been great to have .failing becoming available after recent modernisation, which naturally leads to implementing a .noop version of the dependency too, but it isn't possible currently. Was there a reason for keeping init internal?

stephencelis commented 2 years ago

No reason, I don't think! I think we're relying on the synthesized memberwise initializer. If you'd like to PR an explicit, public one I don't see anything wrong with adding it! I could also see including the .noop version in the PR.