search

pointfreeco / composable-core-location

A library that bridges the Composable Architecture and Core Location.
MIT License
107 stars 56 forks source link

Update library to work with TCA 0.57 #35

Closed klundberg closed 11 months ago

klundberg commented 1 year ago

This change updates all references to Effect to EffectPublisher, and cleans up a few warnings with LocationManager.failing by using the more recent XCTUnimplemented function, though it doesn't update the signature to use a function at this time. This should let the library compile for versions of tca >= 0.43 (when EffectPublisher was introduced), including 0.57 which broke the old 2-generic clause Effect.

I've confirmed that tests pass on tca 0.43 and 0.57, but not on versions in between.

guillermoanaya commented 1 year ago

Is there a plan to migrate this to use the 1.0.0 version?

3a4oT commented 11 months ago

From a build log seems like CI's simulator destination needs to be updated to iPhone 14 simulator instead of iPhone 11 Pro Max? Do you need help to land it? cc @stephencelis

klundberg commented 11 months ago

Hoping things pass now; I modifies the example code+tests to also build with the newest non-1.0 tca and tweaked the makefile to use newer tv/watch simulators for safety as well.

I had to remove a bunch of @available(x, unavailable) annotations from the interface properties since swift in xcode 15 complained about them too