search

pointfreeco / isowords

Open source game built in SwiftUI and the Composable Architecture.
https://www.isowords.xyz
Other
2.7k stars 222 forks source link

Fix Settings from Home #171

Closed tgrapperon closed 1 year ago

tgrapperon commented 1 year ago

This reinstalls the Setting reducer in Home reducer. It was most likely left behind during the "protocol" conversion.

As Reduce and the other ifLet reducers are not effectively handling .settings actions, they all commute with Settings, so this reducer can be installed arbitrarily at the end of the reducer's chain with the other child reducers.

This should fix #170

I also took the liberty to modernize homogenous EmptyReducer().ifCaseLet… into Scope(state: /CasePath…, but I can revert if you prefer.

acosmicflamingo commented 1 year ago

LGTMBWDIK (Looks good to me but what do I know) ;)

tgrapperon commented 1 year ago

I think this commit fixes the issue, so I'm closing this PR.

acosmicflamingo commented 1 year ago

Sounds good!