search

pointfreeco / isowords

Open source game built in SwiftUI and the Composable Architecture.
https://www.isowords.xyz
Other
2.67k stars 217 forks source link

Add explicit module namespace to usages of func `unimplemented` on `ServerEnvironment.unimplemented` #178

Closed mltbnz closed 1 year ago

mltbnz commented 1 year ago

I wanted to run the server app but faced some compiler errors:

Screenshot 2023-05-18 at 22 06 04

To make it compile again I added the explicit namespace of the module on calls to unimplemented() Seems Swift does have issues with the naming. I am following a lot of the best practices applied in this and other repos of pointfree and while renaming some static let test: Self to unimplemented I also encountered some issues with the naming of properties.

I am happy to drill down to the root of the issue if you can give me a pointer :)

Note: Running Xcode 14.2

mbrandonw commented 1 year ago

Hi @mltbnz, thanks for the PR! This will actually be solved in this PR #177, in particular right here. We now use the testValue for the dependency, and that avoids the naming conflict.