pointfreeco / swift-composable-architecture

A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
https://www.pointfree.co/collections/composable-architecture
MIT License
12.35k stars 1.44k forks source link

Branch prerelease/1.0 is not compiling #1924

Closed Malauch closed 1 year ago

Malauch commented 1 year ago

Description

I noticed that commit recent commit 4d5cb6dc36d9e0955b0b205cce8826901a925788 on prerelease/1.0 branch is not compiling (Xcode 14.2). Error messages:

Zrzut ekranu 2023-02-18 o 10 36 56

However earlier commit 8db9e20b0ad86ce6c4875e2f3928bc7b7c412bee compiles without any problem. Main branch is also compiling without any error.

I tried to clean build folder and compile from fresh start and compile error is persistent.

Checklist

Expected behavior

TCA package should compile without errors.

Actual behavior

TCA doesn't compile.

Steps to reproduce

  1. Link TCA in your package/project using prerelease/1.0 branch or 4d5cb6dc36d9e0955b0b205cce8826901a925788 revision.
  2. Try to compile project/package.

The Composable Architecture version information

4d5cb6dc36d9e0955b0b205cce8826901a925788

Destination operating system

No response

Xcode version information

14.2

Swift Compiler version information

5.7.2
ibrahimkteish commented 1 year ago

I have the same problem

tgrapperon commented 1 year ago

Indeed, this is a collateral effect of #1911. A few "free" Send needed to be qualified to Effect<Action>.Send. I've submitted #1926 that should fix the issue.

stephencelis commented 1 year ago

Fixed by #1926. Thanks @tgrapperon!