Closed larryonoff closed 1 year ago
Hi @larryonoff, are you able to reproduce this in a simple project so that we can see what is going on?
And can you expand a bit more on what you mean here:
BTW. Release 0.54.0 has issue only with navigationIDPath, when navigation-beta branch had issue with dismiss and navigationIDPath.
Hi @larryonoff, are you able to reproduce this in a simple project so that we can see what is going on?
And can you expand a bit more on what you mean here:
BTW. Release 0.54.0 has issue only with navigationIDPath, when navigation-beta branch had issue with dismiss and navigationIDPath.
I'll try to make simple project in a few days. If not, I'll give you access to one of my private projects.
BTW. Release 0.54.0 has issue only with navigationIDPath, when navigation-beta branch had issue with dismiss and navigationIDPath.
I mean that previously (before release) there were two undefined symbols errors as on the screenshot
Undefined symbol: _$s 12Dependencies16DependencyValuesV22ComposableArchitectureE 16navigationIDPathAD010NavigationGOVACTKg
the same as in releaseUndefined symbol: _$s12Dependencies16DependencyValuesV22ComposableArchitectureE7dismissAD13DismissEffectVpACTkq
. This's not present in release.Having same issue with private project when archiving (which I can't share) on TCA 0.54.0. But perhaps I'll try to replicate with a sample project as well.
@larryonoff @mbrandonw
I found an open source project that uses TCA and replicated the error!
https://github.com/prose-im/prose-app-macos
Just update signing info and then run the "Release" target
get this similar error about nativationIDPath:
error:
If I change the swift-composable-architecture version to .upToNextMinor(from: "0.53.0") it resolves to TCA 0.53.2 and builds and runs successfully:
@mbrandonw Any updated on this one?
Hi everyone, thanks for the sample project! We were able to reproduce the problem. It appears to be a Swift bug related to inlining. Removing the inlineable from NavigationID
makes it work again:
We will get a fix out soon.
@mbrandonw thanks! looking forward to bugfix.
Version 0.54.1 works now! Thank you!
Description
Application doesn't compile for release configuration.
Please see the error on attachment.
BTW. Release 0.54.0 has issue only with
navigationIDPath
, whennavigation-beta
branch had issue withdismiss
andnavigationIDPath
.The same issue happens for @ski-u
PS. I decided to create issue, since issue happens for 3 of my projects. And I still don't know how to resolve it
Checklist
main
branch of this package.Expected behavior
Application compiles in release configuration.
Actual behavior
Application doesn't compile in release configuration.
Steps to reproduce
No response
The Composable Architecture version information
0.42.0
Destination operating system
No response
Xcode version information
14.3.1
Swift Compiler version information