2FA View not appearing in Tic-Tac-Toe demo

[JOyo246]

Description

When using an email with "2fa" the reducer does correctly set state..

-     _twoFactor: nil
+     _twoFactor: TwoFactor.State(
+       _alert: nil,
+       code: "",
+       isFormValid: false,
+       isTwoFactorRequestInFlight: false,
+       token: "deadbeef"
+     )

However the 2fa does not get presented.

Checklist

• [X] I have determined whether this bug is also reproducible in a vanilla SwiftUI project.
• [X] If possible, I've reproduced the issue using the main branch of this package.
• [X] This issue hasn't been addressed in an existing GitHub issue or discussion.

Expected behavior

I expect the 2fa flow to present.

Actual behavior

The 2fa flow is not presented

Steps to reproduce

1. Run Tic-Tac-Toe sample
2. select SwiftUI
3. enter an email that contains the chars, 2fa.
4. enter password: "password
5. select log in

The Composable Architecture version information

0.54.1

Destination operating system

iOS 16.4

Xcode version information

Xcode 14.3

Swift Compiler version information

No response

[sehdich]

I also can reproduce the issue. What I've found out so far, it's may related to the .navigationDestination(...) as it works as expected when presenting it via a .sheet(...). (LoginView.swift L.66)

[stephencelis]

Looks like that demo was still using NavigationView, which is incompatible with navigationDestination. It definitely worked at some point during the nav beta, so must've been lost somehow. Should be fixed again when we merge https://github.com/pointfreeco/swift-composable-architecture/pull/2264