search

pointfreeco / swift-composable-architecture

A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
https://www.pointfree.co/collections/composable-architecture
MIT License
12.35k stars 1.44k forks source link

NavigationLink in iOS17 usage #2748

Closed tigline closed 8 months ago

tigline commented 8 months ago

Description

In the example SwiftCaseStudies-> "NavigateAndLoadList"

the NavigationLink get the warning :'init(_:tag:selection:destination:)' was deprecated in iOS 16.0: use NavigationLink(value:label:), or navigationDestination(isPresented:destination:), inside a NavigationStack or NavigationSplitView

I will use iOS 17 as base version. So when will the example fix to adapter to iOS 17. I have try but failed.

Checklist

Expected behavior

NavigationLink in example SwiftCaseStudies->"NavigateAndLoadList" fix to match the iOS 17.

Actual behavior

NavigationLink in example SwiftCaseStudies-> "NavigateAndLoadList" in iOS 17 has warning

Steps to reproduce

Just open example SwiftCaseStudies->"NavigateAndLoadList"

The Composable Architecture version information

1.7

Destination operating system

iOS 17

Xcode version information

lastest

Swift Compiler version information

swift 5.9
mbrandonw commented 8 months ago

Hi @tigline, can you describe more what the issue is here? It's true that the NavigateAndLoadList case study is using a deprecated NavigationLink initializer, but the purpose of that case study is to show how to perform navigation in order versions of iOS.

Since this is not an issue with the library I am going to convert it to a discussion.