pointfreeco / swift-composable-architecture

A library for building applications in a consistent and understandable way, with composition, testing, and ergonomics in mind.
https://www.pointfree.co/collections/composable-architecture
MIT License
12.25k stars 1.42k forks source link

Migration to 1.8 & 1.9.x Fails Documentation Builds #2921

Closed xaverlutz closed 6 months ago

xaverlutz commented 6 months ago

Description

Hi,

after migrating our app to 1.8 and adjusting the Destination enums, we are unable to build the documentation using either Xcode or the xcodebuild command. The error can be seen in the image below.

documentation-error

The error is from my dummy project, as I wanted to verify if we migrated something wrong. The project can be accessed at this link.

Checklist

Expected behavior

No response

Actual behavior

No response

Steps to reproduce

  1. Migrate an app to v1.8 & use a destination enum reducer
  2. Try to build the documentation (either with Xcode or xcodebuild command)

The Composable Architecture version information

1.8 & 1.9.2

Destination operating system

iOS 17.0

Xcode version information

Version 15.3 (15E204a)

Swift Compiler version information

1.90.11.1 Apple Swift version 5.10 (swiftlang-5.10.0.13 clang-1500.3.9.4)
mbrandonw commented 6 months ago

Hi @xaverlutz, are you sure this is a TCA-specific issue? It seems more likely that it's a Swift/DocC bug where docs fail to build anytime a macro is involved that generates inner types. Can you try reproducing the problem in a fresh project without TCA involved, and if you succeed then I think this needs to be filed with Apple. I'm not sure there is much we can do to fix this.

mbrandonw commented 6 months ago

Hi @xaverlutz, I'm going to move this to a discussion since I'm not sure it's actually a TCA-specific issue. Sounds like a general Swift/macro issue. Please let us know if you uncover anything new.